search

google / cloud-forensics-utils

Python library to carry out DFIR analysis on the Cloud
Apache License 2.0
452 stars 89 forks source link

Broken Azure unit test #456

Closed jonathan-greig closed 1 year ago

jonathan-greig commented 1 year ago

Fixes #455

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@aa7c5c9). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage        ?   59.17%           
=======================================
  Files           ?       49           
  Lines           ?     4051           
  Branches        ?        0           
=======================================
  Hits            ?     2397           
  Misses          ?     1654           
  Partials        ?        0
Flag Coverage Δ
nosetests 59.17% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ramo-j commented 1 year ago

This will keep happening every time there's a new version released. Is there a way to extract the version that gets installed, and then dynamically mock it?

Something like the following comes to mind

version = extractVersion('azure.mgmt.storage')
@mock.patch(f'azure.mgmt.storage.{version}.operations._storage_accounts_operations.StorageAccountsOperations.list_keys')