Privet on Windows - Githubissues

google / cloud-print-connector

Google Cloud Print Connector

BSD 3-Clause "New" or "Revised" License

764 stars 185 forks source link

Privet on Windows #246

Open agoode opened 8 years ago

agoode commented 8 years ago

Support privet on windows.

mfly commented 8 years ago

@agoode what is currently the biggest challenge with this issue?

agoode commented 8 years ago

Figuring out how to publish an DNS-SD service on Windows. http://stackoverflow.com/questions/23624525/standard-mdns-service-on-windows

There seem to be two options:

https://msdn.microsoft.com/en-us/library/windows/apps/windows.networking.servicediscovery.dnssd.aspx (for Windows 10 only?)
https://developer.apple.com/downloads/index.action?q=Bonjour%20SDK%20for%20Windows (not sure how to use this yet)

jay0lee commented 8 years ago

My apologies, git on Windows got the better of me and I accidentally committed direct instead of doing a PR. Should be reverted now and will get the PR together (carefully).

jay0lee commented 8 years ago

Submitted as PR #306

I did my own digging and as @agoode mentions there are 2 real choices for mDNS on Windows. Native is always good but unless MS plans to backport Windows 10 DNS-SD support to at least Windows 8 / 2008 I think it's a bad choice for now since it severely limits customer OS choice.

Apple's Bonjour is a free download which we may even be able to include with the MSI (TBD). https://github.com/andrewtj/dnssd seems to be a good wrapper for it that I used in the pull request.

agoode commented 8 years ago

I enabled the new review required option for master, to hopefully avoid an accidental push in the future.