Closed cwlls closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I signed it!
CLAs look good, thanks!
Thanks for the quick fix @cevanwells . Not sure what the hold-up is in getting it accepted, but it's fine for me locally (and unblocks the container I was trying to deploy).
It looks like travis-ci is choking when compiling gpc with go 1.5 and 1.6 on the macOS platform. I'm not sure, but I don't think it's my change causing the issue, but the pull request is getting blocked anyway.
I'm glad the fix got you going. I was in a pinch and I was also glad the patch worked.
Chris W.
Thanks for the pull request! I think a better fix is in #397, because we don't want to panic unnecessarily. I'm guessing it might have been causing the other build failures also.
I'm going to close this now, but please reopen if somehow the other request gets stalled again.
The uuid.NewV4() function apparently sends back multiple values (UUID and err). Upon looking at the uuid.go code I noticed that there was a Must() function that is supposed to wrap functions like NewV4(). I have added the wrapper and now the gcp-connector-util appears to compile correctly.
As a side note, I know next to nothing about golang, so somebody should definitely make sure this is doing what is expected and not simply making the compiler happy.