google / cloud-print-connector

Google Cloud Print Connector
BSD 3-Clause "New" or "Revised" License
764 stars 184 forks source link

Fix/Workaround FTBFS issues: #476 #477

Closed rafaeldtinoco closed 3 years ago

rafaeldtinoco commented 4 years ago

Close: 476

Hello, this is a quick attempt of fixing FTBFS in Ubuntu:

1) New CUPSs do not provide _IPP_PRIVATE_STRUCTURES feature. Missing IPP internal data should be acquired by using the proper new functions provided by CUPS.

2) For some reason, cloud-print-connection was FTBFS because of golang-github-codegangsta-cli-dev, complaining about types. (codegangsta-cli-dev hasn't changed from previous working version in Ubuntu).

3) Also, for some reason, golang-github-urfave-cli-dev is having problems with BoolFlag DefaultText field. We have moved from previous working version 1.20.0-1 to 1.22.2-1 in recent Ubuntu.

Of course I don't expect these patches to be accept "as-is", but, if they work, they could be added in the beginning in our binary packages if it proves to solve our dependency issues (among other packages).

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

rafaeldtinoco commented 4 years ago

@googlebot I signed it!

googlebot commented 4 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

rafaeldtinoco commented 4 years ago

I saw the redefinition of _IPP variables (likely your CI has the old cups with _IPP_PRIVATE_STRUCTURES feature. I'll re-push something else, checking that).

rafaeldtinoco commented 4 years ago

I just heard this will be EOL soon. I'll probably include this (or similar) patches in Ubuntu until package is removed from the distro. Thank you!

rafaeldtinoco commented 4 years ago

Although its likely not worth changing upstream code (if this is really EOL), I have pushed needed patches to compile recent code in latest Ubuntu (Focal). For Focal, we only required to private IPP workaround.