Use Gerrit for code reviews

google / clusterfuzz

Scalable fuzzing infrastructure.

https://google.github.io/clusterfuzz

Apache License 2.0

5.27k stars 551 forks source link

Open Dor1s opened 4 years ago

Dor1s commented 4 years ago

GitHub code review is very poor and sometimes hurts productivity. Dart project has instructions on how to use Gerrit to review changes for their GitHub repo: https://github.com/dart-lang/sdk/wiki/Code-review-workflow-with-GitHub-and-Gerrit

I propose we spin up a Gerrit instance and follow the same approach.

oliverchang commented 4 years ago

I do agree in GitHub code review is not as good as Gerrit.. but as counterarguments:

People are generally familiar with github code review. Gerrit may introduce barriers for other contributors.
We would lose the nice integration between issue tracker/other parts of github UI and PRs.

IMO we can probably live with the limitations of Github code reviews, rather than alienate potential contributors.

Dor1s commented 4 years ago

IMO we can probably live with the limitations of Github code reviews

I can't find words to reply, so here comes a disappointed wombat

wombat