search

google / clusterfuzz

Scalable fuzzing infrastructure.
https://google.github.io/clusterfuzz
Apache License 2.0
5.31k stars 556 forks source link

Fix linting errors in src/local/butler/scripts/setup.py #4051

Open jonathanmetzman opened 4 months ago

jonathanmetzman commented 4 months ago

They look like they are from the python upgrade:

src/local/butler/scripts/setup.py:372:17: E1101: Instance of 'MetricServiceClient' has no 'project_path' member (no-member)
src/local/butler/scripts/setup.py:385:8: E1121: Too many positional arguments for method call (too-many-function-args)
src/local/butler/scripts/setup.py:389:8: E1121: Too many positional arguments for method call (too-many-function-args)
vitorguidi commented 4 months ago

There is a migration guide to monitoring >=2.0, from this stack overflow post. Gonna look into this

vitorguidi commented 4 months ago

https://github.com/google/clusterfuzz/pull/4062

Verified the setup.py butler script works, this should do the trick

python butler.py run setup --config-dir ../clusterfuzz-config/configs/internal --non-dry-run
...

Done

Please remember to run the migration individually on all projects.