search

google / clusterfuzz

Scalable fuzzing infrastructure.
https://google.github.io/clusterfuzz
Apache License 2.0
5.26k stars 551 forks source link

Revert "Add `llvm-symbolizer` to PATH for `Centipede` (#4068)" #4077

Closed jonathanmetzman closed 1 month ago

jonathanmetzman commented 1 month ago

This reverts commit d68dd225fbd328e39c33039ee29edd3a4010628d.

jonathanmetzman commented 1 month ago

This is broken: https://pantheon.corp.google.com/errors/CNDM87iS0NnPNA?project=google.com:clusterfuzz&time=P30D&utm_source=error-reporting-notification&utm_medium=email&utm_content=new-error

jonathanmetzman commented 1 month ago

PermissionError: [Errno 13] Permission denied: '/bin/llvm-symbolizer'

at .copyfile ( /usr/local/lib/python3.7/shutil.py:121 ) at .copy ( /usr/local/lib/python3.7/shutil.py:248 ) at ._add_llvm_symbolizer ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/fuzzers/centipede/engine.py:67 ) at ._get_runner ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/fuzzers/centipede/engine.py:72 ) at .fuzz ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/fuzzers/centipede/engine.py:240 ) at .run_engine_fuzzer ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/utasks/fuzz_task.py:1130 ) at .do_engine_fuzzing ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/utasks/fuzz_task.py:1404 ) at .run ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/utasks/fuzz_task.py:1702 ) at .utask_main ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/utasks/fuzz_task.py:1843 ) at .uworker_main_no_io ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/utasks/init.py:211 ) at .execute_locally ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/task_types.py:63 ) at .execute ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/task_types.py:105 ) at .run_command ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/commands.py:218 ) at .process_command_impl ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/commands.py:431 ) at .wrapper ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/commands.py:159 ) at .process_command ( /mnt/scratch0/clusterfuzz/src/clusterfuzz/_internal/bot/tasks/commands.py:249 ) at .task_loop ( /mnt/scratch0/clusterfuzz/src/python/bot/startup/run_bot.py:146 )

DonggeLiu commented 1 month ago

Oh I think I know why: I should not copy it directly to /bin. I should probably add the build_dir (or a new dir with llvm-symbolizer only) to $PATH instead.

Strange that this did not break locally, I will test and submit a new PR tmr.