google / codesearch

Fast, indexed regexp search over large file trees
http://swtch.com/~rsc/regexp/regexp4.html
BSD 3-Clause "New" or "Revised" License
3.66k stars 375 forks source link

build failed on tip of golang #12

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
On tip 59fdb5d05e04 of golang, buiild of pkg index failed because of argument 
type mismatch.
# code.google.com/p/codesearch/index
src/code.google.com/p/codesearch/index/mmap_bsd.go:34: cannot use f.Fd() (type 
uintptr) as type int in function argument

Original issue reported on code.google.com by minux...@gmail.com on 13 Feb 2012 at 8:30

GoogleCodeExporter commented 9 years ago
It's because of: 
http://code.google.com/p/go/source/detail?r=d39a981f1883206abe203bada18c465e5910
c1a1

The change move switches the return value of f.Fd() from an int to a uintptr.  
Converting the value back to an int fixes the build on my Mac and  Linux 
machines.  I can only assume a similar fix exists for the Windows mmap version, 
but I don't have anything I can test that with.

I've attached the two trivial patches.

Original comment by dgryski on 13 Feb 2012 at 8:36

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed by 
https://code.google.com/p/codesearch/source/detail?r=91c15f6c24caea1104a91ee1d14
23440f98a8e5c

Original comment by dgryski on 2 May 2012 at 8:49