Windows missing conversion

google / codesearch

Fast, indexed regexp search over large file trees

http://swtch.com/~rsc/regexp/regexp4.html

BSD 3-Clause "New" or "Revised" License

3.62k stars 373 forks source link

Windows missing conversion #34

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago

In mmap_windows.go line 26:

h, err := syscall.CreateFileMapping(f.Fd(), nil, ...

Need convert to syscall.Handle:

h, err := syscall.CreateFileMapping(syscall.Handle(f.Fd()), nil,

Original issue reported on code.google.com by daniel.p...@gmail.com on 6 Nov 2013 at 5:17

GoogleCodeExporter commented 9 years ago

thanks for sharing this

Original comment by zhuang...@gmail.com on 19 Feb 2014 at 9:35

Added labels: ****
Removed labels: ****

dgryski commented 9 years ago

Fixed by https://github.com/google/codesearch/pull/40 . This issue should be closed.