search

google / codesearch

Fast, indexed regexp search over large file trees
http://swtch.com/~rsc/regexp/regexp4.html
BSD 3-Clause "New" or "Revised" License
3.62k stars 373 forks source link

cgrep line numbers are 0-indexed #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
They should be 1-indexed.

This is from the mac 64 zip file e0e01b6d3c01a3ac8b8d0507aae7cb34ba24b1a7 Jan 
19 2012.

-rob

Original issue reported on code.google.com by r@golang.org on 21 Jan 2012 at 4:31

GoogleCodeExporter commented 9 years ago 
For those of you playing along at home, the line to fix is the declaration of 
'lineno' at regexp/match.go:404 from being initialized to 0 to being 
initialized to 1.

Original comment by dgryski on 29 Jan 2012 at 9:24

GoogleCodeExporter commented 9 years ago 
Fixed by 
https://code.google.com/p/codesearch/source/detail?r=409f3e2a1a0d84a7c692aa7530d
317f931c496e7

Original comment by dgryski on 2 May 2012 at 8:48

GoogleCodeExporter commented 9 years ago 
Issue 25 has been merged into this issue.

Original comment by dgryski on 11 Oct 2012 at 1:04