search

google / codesearch

Fast, indexed regexp search over large file trees
http://swtch.com/~rsc/regexp/regexp4.html
BSD 3-Clause "New" or "Revised" License
3.65k stars 375 forks source link

index: fix bug in siftUp #47

Closed dgryski closed 5 years ago

dgryski commented 9 years ago

Fixes #35

dgryski commented 9 years ago

This is just taking the attached patches from #35 and making a github pull request.

I agree there is a bug in siftUp(), but I'm not entirely sure why it doesn't manifest itself in production.

pombredanne commented 8 years ago

Any reason why this is not merged in master?

dgryski commented 8 years ago

Mostly because @rsc is busy with other things.

dgryski commented 7 years ago

I just hit this with my current corpus. I had added a panic() to mergePost() in case I ever tried to merge out-of-order elements and for the first time today it fired. So, indeed this does happen in production, but clearly it is rare.

Pinging @rsc again to get this merged.

pombredanne commented 7 years ago

@dgryski may be Russ has lost interest in this codebase or has not the time to handle this at all? I can see that @dominikh and especially @junkblocker have reasonably active forks. May it would be time to take over the code and maintain it entirely elsewhere? Just food for subversive thoughts

dgryski commented 7 years ago

And both forks have included the siftUp() patch too. I agree the README should probably be updated to point to the other maintained forks.