Adding "rc" as a parameter to openh264

alvestrand commented 9 years ago

This allows the "rc" parameter to be varied in order to try different styles of rate control. Best results are achieved with -rc 2, which has no rate control, but better compression.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

googlebot commented 9 years ago

CLAs look good, thanks!

phoglund commented 9 years ago

lgtm (assumed you wanted me to review)

google / compare-codecs

Adding "rc" as a parameter to openh264 #54