google / compare-codecs

Apache License 2.0
49 stars 23 forks source link

Add "--threads" parameter to x264 codec. #56

Closed alvestrand closed 9 years ago

alvestrand commented 9 years ago

This adds a parameter for controlling the number of threads to the x264 codec, removing the previously hardcoded default. NOTE: WILL INVALIDATE STORED ENCODES.

It also adds a new tool "vary_parameter" that lets one run encodes for all possible values of a parameter, so that response curves can be seen.

It also fixes a minor Lint error in openh264.py.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


alvestrand commented 9 years ago

Another email address added to profile and verified.

alvestrand commented 9 years ago

I signed it!

phoglund commented 9 years ago

Assign me if you want this reviewed.

alvestrand commented 9 years ago

Chiefly pushing this to test the CLA-bot. It's awaiting feedback from the x264 developers, since it seems to impact performance negatively along at least 2 axes (PSNR and total amount of CPU used). Review can wait until x264 folks give feedback.

alvestrand commented 9 years ago

Verified with x264 folks that the results I observe is what they expect me to see. Please review.

phoglund commented 9 years ago

Had some minor comments.

alvestrand commented 9 years ago

Updates submitted!

phoglund commented 9 years ago

lgtm