Closed alvestrand closed 9 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
Another email address added to profile and verified.
I signed it!
Assign me if you want this reviewed.
Chiefly pushing this to test the CLA-bot. It's awaiting feedback from the x264 developers, since it seems to impact performance negatively along at least 2 axes (PSNR and total amount of CPU used). Review can wait until x264 folks give feedback.
Verified with x264 folks that the results I observe is what they expect me to see. Please review.
Had some minor comments.
Updates submitted!
lgtm
This adds a parameter for controlling the number of threads to the x264 codec, removing the previously hardcoded default. NOTE: WILL INVALIDATE STORED ENCODES.
It also adds a new tool "vary_parameter" that lets one run encodes for all possible values of a parameter, so that response curves can be seen.
It also fixes a minor Lint error in openh264.py.