google / compare-codecs

Apache License 2.0
49 stars 23 forks source link

ChangeValue should be CreateVariant #58

Open alvestrand opened 9 years ago

alvestrand commented 9 years ago

Since the parameters.ChangeValue function returns a new parameter block (and similar for its echoes up the stack), it ought to be called something that implies it doesn't change its argument. CreateVariant is one possible name - ModifiedObject would be another.

39 occurences so far.