google / compare-codecs

Apache License 2.0
49 stars 23 forks source link

Make bad configurations cause errors. #59

Closed alvestrand closed 9 years ago

alvestrand commented 9 years ago

This makes configurations with:

Unrecognized parameters are still allowed.

The "verify_hashnames" script has been renamed to "verify_stored_parameters" and changed a bit to reflect that it also checks that parameters can be parsed.

googlebot commented 9 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


alvestrand commented 9 years ago

I signed it!

googlebot commented 9 years ago

CLAs look good, thanks!

phoglund commented 9 years ago

Had some comments.

phoglund commented 9 years ago

lgtm