spectral_norm_update_ops unused?

google / compare_gan

Compare GAN code.

Apache License 2.0

1.82k stars 319 forks source link

spectral_norm_update_ops unused? #12

Closed nwestlake closed 5 years ago

nwestlake commented 6 years ago

My understanding is that spectral_norm_update_ops in compare_gan/src/gans/ops.py is not used at all and perhaps wasn't used. Is my understanding correct?

xiaohuazhai commented 5 years ago

Thanks Nicholas, The spectral norm function is actually called via "def spectralnorm(input)", in the operation linear and conv2d. https://github.com/google/compare_gan/blob/560697ee213f91048c6b4231ab79fcdd9bf20381/compare_gan/src/gans/ops.py#L63

The function spectral_norm_update_ops is deprecated and we will remove the unused code in the future release.