search

google / compare_gan

Compare GAN code.
Apache License 2.0
1.82k stars 319 forks source link

[bug] raise when real dataset has not enough examples in evaluation #32

Open anth2o opened 5 years ago

anth2o commented 5 years ago

This PR fixes a bug in the evaluation. If the real dataset has not enough samples in the test set, an exception is raised.

googlebot commented 5 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Marvin182 commented 5 years ago

Thanks a lot. Can we use tf.errors.OutOfRangeError instead of defining a new exception?

anth2o commented 5 years ago

tf.errors.OutOfRangeError needs 'node_def', 'op', and 'message' to be raised, so I decided to raise a custom Exception which was more explicit. But if you prefer, I can raise the original exception.