google / comprehensive-rust

This is the Rust course used by the Android team at Google. It provides you the material to quickly teach Rust.
https://google.github.io/comprehensive-rust/
Apache License 2.0
27.45k stars 1.63k forks source link

Fix _text_ in Koran translation. #432

Open jooyunghan opened 1 year ago

jooyunghan commented 1 year ago

_text_ doesn't work when it's in the middle of a word: e.g. Abcdef

In Korean translation, there's so many cases due to postposition (-이/가, -을/를, -은/는..) in Korean language system.

Note *text* works: e.g. Abcdef.

Ideas:

Btw, in Korean, we don't use italic to emphasize in general. Instead, we use bold or 'quote'. I'd like to avoid italic in Korean translation.

mgeisler commented 1 year ago
  • use *text* instead
  • fix MD parser to support _text_

Are you suggesting updating the English text to use * instead of _? I think we're mostly using * right now, but it turns out that we have guidelines for this and they ask us to use _ instead: https://developers.google.com/style/text-formatting.

My plan is to reformat everything to be consistent when #318 is fixed. I'm hoping to find a volunteer to fix that issue before I do it myself :smile:

Btw, in Korean, we don't use italic to emphasize in general. Instead, we use bold or 'quote'. I'd like to avoid italic in Korean translation.

Okay, I love that you take that into account in the translation! You should not feel tied to the English source text (and it's formatting) here. So please translate *text* into **text** as you see fit in the Korean translation.

jooyunghan commented 1 year ago

I thought only fixing in the Korean translation 😃

mgeisler commented 1 year ago

I thought only fixing in the Korean translation smiley

Okay, sounds great then!

jooyunghan commented 1 year ago

Todo:

jooyunghan commented 1 year ago

https://www.korean.go.kr/news/index.jsp?control=page&part=view&idx=10192&preview=null says 블록 is right.

mgeisler commented 1 year ago

Hi @jooyunghan, is this still something that we need to fix?