Expand Retry Logic - Githubissues

google / containerregistry

A set of Python libraries and tools for interacting with a Docker Registry.

https://gcr.io

Apache License 2.0

204 stars 116 forks source link

Expand Retry Logic #105

Open jpoehnelt opened 6 years ago

jpoehnelt commented 6 years ago

It would be nice if the pusher retried on 504s and other similar responses that occur when backends are having issues. For example, today: https://status.cloud.google.com/incident/cloud-dev-tools/18003#18003003

drigz commented 5 years ago

+1, I ran into this when pushing multiple images in parallel to a newly created projects (with rules_docker's container_push). The first request succeeds, but the next 10 or so fail with a 503.

fahhem commented 4 years ago

We've (not Google) done this by overriding/extending the ShouldRetry function in the RetryTransport class, which was nicely setup to allow that. Is that useful?