google / containerregistry

A set of Python libraries and tools for interacting with a Docker Registry.
https://gcr.io
Apache License 2.0
206 stars 115 forks source link

Fix encoding bug when calling Popen.communicate #138

Closed peterebden closed 4 years ago

peterebden commented 5 years ago

communicate expects a bytes-like thing for input; was erroring out with

memoryview: a bytes-like object is required, not 'str'

Depends on the destination repo whether that codepath is hit or not though so doesn't happen every time.

jonjohnsonjr commented 4 years ago

Landed in https://github.com/google/containerregistry/pull/160