Open gsemet opened 3 years ago
Hi,
Yes, Copybara architecture is thought of so that new types of components can be added (Like Gitlab). We would be happy to accept contributions
Cheers, Mikel.
On Wed, Dec 9, 2020 at 3:17 AM Gaetan Semet notifications@github.com wrote:
Hi.
I wonder if a Gitlab integration would be imaginable somewhere in the future, especially to mirror incoming public contribution to merge request on the internal SoT, and closing them elegantly? Look like the integration on Gerrit and Github and pretty fine, but on other systems we need to do some manual cleanup.
Thanks
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/google/copybara/issues/153, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHJWQHVPVKL5R6FGTLERQLST4XDFANCNFSM4UTD6DPA .
@mikelalcon what is your opinion regarding using something like https://github.com/gitlab4j/gitlab4j-api (MIT license) instead of having to implement the API client from scratch like what you have here for Github? That could save the implementation effort quite a bit.
I would need to look at it but it is difficult:
- We would need the dependency internally
- The framework has to be able to plug http transports, security, etc.
Hi guys! Any progress here?
No, regrettably we had no cycles to work on this. As Mikel mentioned, this would look like the GitHub setup, with the same extension points for alternate transports etc if anybody want to send a PR.
Hi.
I wonder if a Gitlab integration would be imaginable somewhere in the future, especially to mirror incoming public contribution to merge request on the internal SoT, and closing them elegantly? Look like the integration on Gerrit and Github and pretty fine, but on other systems we need to do some manual cleanup.
Thanks