search

google / copybara

Copybara: A tool for transforming and moving code between repositories.
Apache License 2.0
2.13k stars 258 forks source link

Add support for bzlmod #287

Open keith opened 6 months ago

keith commented 6 months ago

Fixes https://github.com/google/copybara/issues/220

keith commented 6 months ago

The hardest part of this integration is to pull in the starlark library from bazel, right now some of the bazel build config is duplicated here, although that should be removable.

Open question: would you be open to dropping the non-bzlmod based build? I haven't touched that yet here, I think we could make both work at once, but we could also delete the old one if it's not necessary with this.

keith commented 6 months ago

It turns out that it's easy enough to keep non-bzlmod working, so I made the minor adjustments required there

hsudhof commented 6 months ago

Funnily enough, I have a very similar change in my local repo and ran into exactly the same issue.

keith commented 3 months ago

we've been using this internally for a while, i think it's good to go

psalaberria002 commented 1 month ago

This has been pending for a while, could someone review it? It would be very nice to have it merged.