Add support for `CUSTOM_TAB_COLOR_RGB` parameter to customize browser tab background (only Android supported at the moment) - Githubissues

google / cordova-plugin-browsertab

A Cordova plugin that provides an interface to in-app browser tabs that exist on some mobile platforms, such as SFSafariViewController on iOS and CustomTabs on Android.

Apache License 2.0

117 stars 147 forks source link

Add support for `CUSTOM_TAB_COLOR_RGB` parameter to customize browser tab background (only Android supported at the moment) #22

Closed aszmyd closed 6 years ago

aszmyd commented 6 years ago

Added support for CUSTOM_TAB_COLOR_RGB param. Usage: cordova plugin add cordova-plugin-browsertab --variable CUSTOM_TAB_COLOR_RGB="#ff0000" to setup custom Android (only Android supported now) browser tab to red background.
Updated code that creates new CustomTabIntent to be up to date with most recent Google docs (https://developer.chrome.com/multidevice/android/customtabs#opening-a chrome custom tab)
Bump version to 0.2.1
Added RELEASENOTES.md file to write down releases changelog
Updated readme

aszmyd commented 6 years ago

I already signed Google CLA

aszmyd commented 6 years ago

Thanks @iainmcgin ! Do you have a plan when it'll be released to npm registry? Unfortunately because plugin is inside plugin folder this one cannot be installed to cordova app from github itself

pbijvani commented 6 years ago

Is this version release? I dont see version 0.2.1 in the release page.

aszmyd commented 6 years ago

@pbijvani its not. In our project, we've switched to other great plugin https://www.npmjs.com/package/cordova-plugin-browsertab-themeable that allows to same customization but during method call, not on plugin install so its more dynamic + it supports iOS theming also.

pbijvani commented 6 years ago

@aszmyd do you mean this plugin?

https://www.npmjs.com/package/cordova-plugin-browsertab-themeable

aszmyd commented 6 years ago

@pbijvani yes