search

google / cordova-plugin-browsertab

A Cordova plugin that provides an interface to in-app browser tabs that exist on some mobile platforms, such as SFSafariViewController on iOS and CustomTabs on Android.
Apache License 2.0
117 stars 147 forks source link

Remove depedency on cordova-plugin-compat #26

Open sebastian-zarzycki-apzumi opened 6 years ago

sebastian-zarzycki-apzumi commented 6 years ago

When using this for cordova-android 7.1.0, it complains about the failed requirement

cordova platform add android
(...)
Installing "cordova-plugin-browsertab" for android
Plugin dependency "cordova-plugin-compat@1.2.0" already fetched, using that version.
Installing "cordova-plugin-compat" for android
Plugin doesn't support this project's cordova-android version. cordova-android: 7.1.0, failed version requirement: 
      <6.3.0
Skipping 'cordova-plugin-compat' for android
Subproject Path: CordovaLib
Subproject Path: app
Installing "cordova-plugin-compat" for android
Plugin doesn't support this project's cordova-android version. cordova-android: 7.1.0, failed version requirement: 
      <6.3.0
Skipping 'cordova-plugin-compat' for android
ghost commented 6 years ago

+1 same issue.

ghost commented 6 years ago

I solved this issue by, downloading the browsertab plugin first and then removing the dependency code in plugins xml file and then removing and adding the cordova-android 6.4.0 and it worked.

I believe it will work the same way in other above version too.

sebastian-zarzycki-apzumi commented 6 years ago

That's not a reliable solution, it will work only on your local machine.

ghost commented 6 years ago

I just suggested if you want to make it build now. Else somebody has to make changes and give new git commit and google has to approve it.

rtm commented 6 years ago

I see that there is a version 0.2.1 in the repo, which has the dependency removed, but it has never been published to npm. Can someone please publish it?

fmalave commented 5 years ago

That's not a reliable solution, it will work only on your local machine.

Hi, @sebastian-zarzycki-es Did you find an alternative solution to this?

sebastian-zarzycki-apzumi commented 5 years ago

I don't remember, honestly. I think I've patched the plugin locally, like @sanvenkur suggested. There's not much to be done, just ask the original maintainer to, well, maintain his work.

fmalave commented 5 years ago

I don't remember, honestly. I think I've patched the plugin locally, like @sanvenkur suggested. There's not much to be done, just ask the original maintainer to, well, maintain his work.

Thanks, I'll try something.

Mdelaf commented 5 years ago

No solution yet? I don't want to patch the plugin locally :expressionless: