Prevents appending a new entry in the AndroidManifest.xml

google / cordova-plugin-browsertab

A Cordova plugin that provides an interface to in-app browser tabs that exist on some mobile platforms, such as SFSafariViewController on iOS and CustomTabs on Android.

Apache License 2.0

117 stars 147 forks source link

Prevents appending a new entry in the AndroidManifest.xml #3

Closed airamrguez closed 7 years ago

airamrguez commented 7 years ago

This plugin adds a new <uses-sdk /> entry in the AndroidManifest file apart from the one that is appended by the Cordova build process. When building the application in release mode it throws an error due to multiple <uses-sdk> elements.

I'm basically replacing config-file, that appends a new entry in the AndroidManifest file, with edit-config that modifies existing elements using a merge strategy.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

prijindal commented 7 years ago

This is really required If i am targeting some other android version that 16 it becomes a pain to add this plugin

iainmcgin commented 7 years ago

I can't accept the pull request until the CLA is signed.

airamrguez commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!