search

google / cordova-plugin-browsertab

A Cordova plugin that provides an interface to in-app browser tabs that exist on some mobile platforms, such as SFSafariViewController on iOS and CustomTabs on Android.
Apache License 2.0
117 stars 147 forks source link

Ionic Capacitor - Import Android is fails #39

Open CarlosFJ opened 3 years ago

CarlosFJ commented 3 years ago

Well, I'm working with this plugin in an Ionic Capacitor project. When the app is synchronized in android, Android Studio not find "import android.support.customtabs.CustomTabsIntent" in BrowserTab.java file.

This issue is resolved to changing the imported line to: androidx.browser.customtabs.CustomTabsIntent.

May I supposed that is a change in Android ?? or an issue ?? Thanks, Carlos.

nampdn commented 3 years ago

I think this package is abandoned, if we want to fix this issue we can use the NPM patch-package to patch this package directly on node_modules as there no more release on this.

Or we can try to use https://github.com/TobyEb/cordova-plugin-colored-browser-tabs instead

mlynch commented 2 years ago

This plugin is unnecessary in Capacitor. Just use the Browser API: https://capacitorjs.com/docs/apis/browser

jpike88 commented 2 years ago

@mlynch this plugin is still required by cordova-plugin-firebasex, it may not be so easy to just dump it. What it needs is a 'revamped' upgrade that allows it just to install properly on recent cordova-android versions

sethrevelle commented 2 years ago

npm install jetifier npx jetify

This keeps the wagon rolling.