search

google / cordova-plugin-browsertab

A Cordova plugin that provides an interface to in-app browser tabs that exist on some mobile platforms, such as SFSafariViewController on iOS and CustomTabs on Android.
Apache License 2.0
117 stars 147 forks source link

cordova/platforms/android/app/src/main/java/com/google/cordova/plugin/BrowserTab.java:21: error: cannot find symbol import android.support.customtabs.CustomTabsIntent; #46

Open danieldanielecki opened 11 months ago

danieldanielecki commented 11 months ago 
cordova/platforms/android/app/src/main/java/com/google/cordova/plugin/BrowserTab.java:21: error: cannot find symbol
import android.support.customtabs.CustomTabsIntent;
                                 ^
  symbol:   class CustomTabsIntent
  location: package android.support.customtabs
cordova/platforms/android/app/src/main/java/com/google/cordova/plugin/BrowserTab.java:104: error: package CustomTabsIntent does not exist
    Intent customTabsIntent = new CustomTabsIntent.Builder().build().intent;
Screenshot 2023-07-29 at 18 35 01

While trying to run this project, already after fixing https://github.com/google/cordova-plugin-browsertab/issues/43.

danieldanielecki commented 11 months ago

Issue can be fixed by replacing import android.support.customtabs.CustomTabsIntent; with import androidx.browser.customtabs.CustomTabsIntent;.

We badly need https://github.com/google/cordova-plugin-browsertab/pull/45 to be approved, then it should work out-of-the-box.

ravi-bozz commented 9 months ago

Issue can be fixed by replacing import android.support.customtabs.CustomTabsIntent; with import androidx.browser.customtabs.CustomTabsIntent;.

We badly need #45 to be approved, then it should work out-of-the-box.

@danieldanielecki did you got any update on #45 ?

danieldanielecki commented 9 months ago

Issue can be fixed by replacing import android.support.customtabs.CustomTabsIntent; with import androidx.browser.customtabs.CustomTabsIntent;. We badly need #45 to be approved, then it should work out-of-the-box.

@danieldanielecki did you got any update on #45 ?

nope; that's not my PR!