Closed bayssmekanique closed 7 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
I have attempted several times to sign the CLA, but it keeps giving me a A server error occurred, please try your request again.
error.
Hey,
Thanks for this contribution! I don't know why you're having trouble with the CLA; if that's still happening I'll try and find someone to help. Unfortunately I can't merge the change until we have confirmation it is signed :(
@iainmcgin, I have tried from multiple computers, using Stable and Canary, incognito mode, even tried from Edge. Same error with all of them. No errors in the console and the actual POST request returns 200, so I'm not certain what to do.
I have contacted support with regards to the CLA, I'll let you know what they find out.
I signed it!
CLAs look good, thanks!
This removes the minSDK from being automatically added to the
AndroidManifest.xml
file and instead checks that a sufficient minSdkVersion only sets a minSdkVersion when necessary.Fixes issue: https://github.com/google/cordova-plugin-browsertab/issues/7