google / cordova-plugin-browsertab

A Cordova plugin that provides an interface to in-app browser tabs that exist on some mobile platforms, such as SFSafariViewController on iOS and CustomTabs on Android.
Apache License 2.0
117 stars 147 forks source link

Fixes Android minSdkVersion override #8

Closed bayssmekanique closed 7 years ago

bayssmekanique commented 7 years ago

This removes the minSDK from being automatically added to the AndroidManifest.xml file and instead checks that a sufficient minSdkVersion only sets a minSdkVersion when necessary.

Fixes issue: https://github.com/google/cordova-plugin-browsertab/issues/7

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


bayssmekanique commented 7 years ago

I have attempted several times to sign the CLA, but it keeps giving me a A server error occurred, please try your request again. error.

iainmcgin commented 7 years ago

Hey,

Thanks for this contribution! I don't know why you're having trouble with the CLA; if that's still happening I'll try and find someone to help. Unfortunately I can't merge the change until we have confirmation it is signed :(

bayssmekanique commented 7 years ago

@iainmcgin, I have tried from multiple computers, using Stable and Canary, incognito mode, even tried from Edge. Same error with all of them. No errors in the console and the actual POST request returns 200, so I'm not certain what to do.

iainmcgin commented 7 years ago

I have contacted support with regards to the CLA, I'll let you know what they find out.

bayssmekanique commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!