Adds a Browser Tab close method for iOS

google / cordova-plugin-browsertab

A Cordova plugin that provides an interface to in-app browser tabs that exist on some mobile platforms, such as SFSafariViewController on iOS and CustomTabs on Android.

Apache License 2.0

117 stars 147 forks source link

Adds a Browser Tab close method for iOS #9

Closed WilliamDenniss closed 7 years ago

WilliamDenniss commented 7 years ago

Builds on #6, by adding an Android NOP implementation and a Readability pass on iOS.

googlebot commented 7 years ago

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

chuchuva commented 7 years ago

Awesome! Thank you very much! How about updating plugin package at https://www.npmjs.com/package/cordova-plugin-browsertab now? /cc @iainmcgin

washowasho commented 6 years ago

So how would this close feature actually work? Like InAppBrowser, if there is no reference in the JS code to detect which URL is currently loaded... how will one know to execute the .close() command?