Fixed Python 3 compatibility

google / corpuscrawler

Crawler for linguistic corpora

Other

190 stars 56 forks source link

Fixed Python 3 compatibility #52

Closed wannaphong closed 4 years ago

wannaphong commented 4 years ago

From #19, I fixed python 3 compatibility.

Colab:

Python 2 https://colab.research.google.com/drive/1WnOrOtsBbx0LOPJ4oCulicqObqOUf6pL
Python 3 https://colab.research.google.com/drive/1ooSQajYFm6v6yOmC-kpm4qjNeGjdx4nl

sffc commented 4 years ago

Thanks for this! I made some more changes locally, testing to make sure my and my-t-d0-zawgyi work in both py2 and py3.

sffc commented 4 years ago

OK, this has been running for a couple hours in all four configurations without any more errors beyond the ones I fixed. I'm going to merge this PR. If any more errors come up, we can fix them as needed.

hugolpz commented 6 months ago

Thank you @wannaphong , @sffc . 🌻