search

google / coset

A set of Rust types for supporting COSE
Apache License 2.0
28 stars 16 forks source link

Implement Error for CoseError #60

Closed janosimas closed 1 year ago

janosimas commented 1 year ago

Is there any reason for CoseError not to implement Error? This causes issues when working with other libraries, like thiserror

daviddrysdale commented 1 year ago

The original reason was because this crate is #[no_std], and Error used to be std-only.

AIUI Error has now moved into core, but I guess that would require a suitable MSRV to use.

In the meanwhile, I guess we could add a (non-default) std feature that adds an Error implementation.

janosimas commented 1 year ago

The std feature looks good to me

daviddrysdale commented 1 year ago

Fixed in #61