google / coset

A set of Rust types for supporting COSE
Apache License 2.0
28 stars 16 forks source link

Support decoding COSE_Sign1_Tagged messages #77

Closed henrylyons closed 1 year ago

henrylyons commented 1 year ago

When I used this crate to decode a COSE_Sign1_Tagged message, I got the following error: "got tag, expected array".

Attached is a COSE_Sign1_Tagged message which can be used to repro this issue. The first byte of this message is D2 (tag value 18) - this value (18) is registered with IANA as Cose_Sign1 (https://www.iana.org/assignments/cbor-tags/cbor-tags.xhtml).

Please add support for decoding COSE_Sign1_Tagged messages, to make this crate more interoperable with other COSE implementations.

repro.zip

daviddrysdale commented 1 year ago

Are you using CoseSign1::from_tagged_slice?

henrylyons commented 1 year ago

This works, thanks for the quick triage.