google / cro3

Abstraction Layer of ChromiumOS development
https://google.github.io/cro3/
BSD 3-Clause "New" or "Revised" License
36 stars 12 forks source link

Add real-time histogram #185

Closed wtrgjadmw closed 10 months ago

wtrgjadmw commented 10 months ago

This PR added a histogram which is repeatedly redrawn while workload runs on DUT.

wtrgjadmw commented 10 months ago

I have just implemented a histogram which is redrawn throughout one iteration yet. As we discussed in the weekly mtg, I'm planning it redraws histogram only while workload runs on DUT. But I'm wondering which is better to separate data array (the one is PowerDataList, which contains all data for line graph and the other contains only the data during workload running for histogram) OR to keep the index of the data when "start"/"end" signal and slice PowerDataList every time when redrawing histogram. I suppose the former method consumes memory but the latter makes codes complicated. Does anyone have advice or comment?

wtrgjadmw commented 10 months ago

As discussed in 1:1 with hikalium, we proceed with the former method because the latter also consumes the memory and takes time to cut out the data.