Add tab completion of branch name

google / cro3

Abstraction Layer of ChromiumOS development

https://google.github.io/cro3/

BSD 3-Clause "New" or "Revised" License

36 stars 12 forks source link

Add tab completion of branch name #216

Closed 4n12i closed 8 months ago

4n12i commented 9 months ago

Add the --branch subcommand
Add tab completion of Android branch name
Use it when the --branch option is specified (e.g. lium vm start command)

mhiramat commented 9 months ago

Basically this idea is OK. But I would like to ask you to change lium config show to show the JSON value of a specific key and use it in lium.bash instead of introducing lium branch list.

4n12i commented 9 months ago

Basically this idea is OK. But I would like to ask you to change lium config show to show the JSON value of a specific key and use it in lium.bash instead of introducing lium branch list.

Thank you for your good idea, I'll update them!

4n12i commented 9 months ago

@hikalium @mhiramat Please add the command lium config set android_branches <BRANCHES> to the lium-installer instead of me after this PR merged!

hikalium commented 8 months ago

LGTM. Thank you!!