search

google / cronet-transport-for-okhttp

This package allows OkHttp and Retrofit users to use Cronet as their transport layer, benefiting from features like QUIC/HTTP3 support or connection migration.
Apache License 2.0
427 stars 31 forks source link

Can you upgrade to Okhttp 4？ #16

Open limuyang2 opened 1 year ago

limuyang2 commented 1 year ago 
// TODO(danstahr): OkHttp 4 can use isOneShot flag here and rewind safely.

Implement this TODO using okhttp4

limuyang2 commented 1 year ago 
override fun rewind(uploadDataSink: UploadDataSink) {
    // TODO(danstahr): OkHttp 4 can use isOneShot flag here and rewind safely.
    if (okHttpRequestBody.isOneShot()) {
        uploadDataSink.onRewindError(Exception("This request can only be transmitted once"))
    } else {
        uploadDataSink.onRewindSucceeded()
    }
}

Is my usage correct?