search

google / csp-evaluator

https://csp-evaluator.withgoogle.com
Apache License 2.0
315 stars 45 forks source link

Problem with latest version 1.0.2 #36

Closed adrianaferrugento closed 3 years ago

adrianaferrugento commented 3 years ago

There seems to be a problem with the new version of csp-evaluator, I keep getting this error now:

Screenshot 2021-08-04 at 14 29 05
lweichselbaum commented 3 years ago

@adamraine can you look into this?

patrickhulce commented 3 years ago

@lweichselbaum between 1.0.1 and 1.0.2 the location of the dist files for the lighthouse folder moved from lighthouse/dist to dist/lighthouse, this breaks lighthouse usage which relies on lighthouse/dist and only locked to ^1.0.1.

Would you be able to revert to the previous directory structure for 1.x and only move to dist/lighthouse in a breaking change?

Hang on sorry, my npm folder structure is just messed up, I cleared out node_modules and now I'm seeing something else, bear with me 😅

OK, for real this time. It looks like dist folder is missing completely in csp_evaluator 1.0.2, would you be able to publish 1.0.3 with the dist files?


$ curl https://unpkg.com/csp_evaluator@1.0.2/dist
Cannot find "/dist" in csp_evaluator@1.0.2
$ curl https://unpkg.com/csp_evaluator@1.0.1/dist
Cannot find an index in "/dist" in csp_evaluator@1.0.1
$ curl --head https://unpkg.com/csp_evaluator@1.0.2/dist/lighthouse/lighthouse_checks.js
HTTP/2 404
$ curl --head https://unpkg.com/csp_evaluator@1.0.1/dist/lighthouse/lighthouse_checks.js
HTTP/2 200
lweichselbaum commented 3 years ago

Sorry for the inconvenience! csp_evaluator@1.0.4 is released and should fix the issue.

ddworken commented 3 years ago

See https://unpkg.com/csp_evaluator@1.0.4/dist/lighthouse/lighthouse_checks.js

adrianaferrugento commented 3 years ago

Amazing, thank you!