google / cyanobyte

Machine-readable datasheets
https://cyanobyte.dev
Apache License 2.0
79 stars 31 forks source link

made changes to BMP280 cyanobytes datasheet #246

Closed rohitsam closed 3 years ago

rohitsam commented 3 years ago

The register size in BMP280 is not matching to what the datasheet shows.

image The compensation parameter values that is valueDT1,valueDT2,valueDT3,valueDP1,valueDP2..... are all 16 bits. Also the valueDT2 is signed value.

image The rawTemp value is mentioned as 16 bit value, which is actually 20 bits so I have changed the rawTemp to 32bit

image The raw pressure value is mentioned as 16-bit value, which is actually 20 bits so I have changed the raw pressure to 32bit

glad to have made my first pull request :blush: Thanks.

Fleker commented 3 years ago

Thanks for sending the pull request. I believe when I originally tried the sensor I was using the Raspberry Pi, which didn't care about bit sizes explicitly.