Improve peripheral naming consistency #85

tlentali commented 5 years ago

Hi @Fleker, I added the upper case name convention and changed the tests files with the correct upper case names. Is it ok for you ?

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

tlentali commented 5 years ago

I signed the Google Contributor License Agreements :) !

tlentali commented 5 years ago

@googlebot I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

tlentali commented 5 years ago

I see that there is an issue on commit b2c. Unittest works in local on this commit, do you see what is wrong ?

Fleker commented 5 years ago

Looks like unit tests are failing (python3 -m unittest discover test) as the sample files will need to be renamed as well.

tlentali commented 5 years ago

You are right, I am on it !

Fleker commented 5 years ago

Unit tests still seem to be failing.

tlentali commented 5 years ago

Unit tests seem ok now !

Fleker commented 5 years ago

Okay, the tests are passing. But can you also update the cloudbuild.yaml with the new filepaths? That's the last step that is failing in the CI.

tlentali commented 5 years ago

Filepaths are correct now :)

Fleker commented 5 years ago

Thanks!

tlentali commented 5 years ago

Thank you very much for your help @Fleker !

google / cyanobyte