AggregateDepsTask cache miss due to inconsistent order

[alextu]

We saw on several occasion a remote cache miss:

• first build runs on CI (linux runner) and populates the cache
• second build runs locally (mac os x) and requests the remote cache

The miss is caused by classpath files of AggregateDepsTask being ordered differently in the 2 builds, see screenshot below:

A quick initial investigation lead me to this suspect: https://github.com/google/dagger/blob/master/java/dagger/hilt/android/plugin/main/src/main/kotlin/dagger/hilt/android/plugin/util/AggregatedPackagesTransform.kt#L49

walkTopDown() does not return files in a consistent order between platforms (or even JDKs ?).

[kuanyingchou]

Hi, @alextu , thanks for reporting this! I've submitted 5b5fcc82c2d031be6bc6607bc9882fb667563559 that sorts walkTopDown(). It should be included in the next release.

[alextu]

Thanks for the quick response!