search

google / detangle

Apache License 2.0
170 stars 16 forks source link

Chrome extension build fails on macOS #1

Open mehdideveloper opened 6 years ago

mehdideveloper commented 6 years ago

Hey Running bazel build chrome_ext fails with this error:

ERROR: /private/var/tmp/_bazel_user1/efaa21b110f06464002c5605311ac560/external/polymer_bundler_repo/BUILD.bazel:5:1: no such package '@vulcanize//': npm_install failed:  (Process terminated by signal 6) and referenced by '@polymer_bundler_repo//:vulcanize_bin'
ERROR: Analysis of target '//chrome_ext:chrome_ext' failed; build aborted: Loading failed
INFO: Elapsed time: 3.898s
FAILED: Build did NOT complete successfully (0 packages loaded)

macOS 10.13.3 node 9.4.0 (npm 5.6.0) bazel 0.9.0

FYI, native_messaging is built successfully.

Update: I built it on Ubuntu and installed the extension on Mac; Also, built the native messaging on Mac. How should I configure the native package? (detanglenm binary). The extension complains that the native package is missing.

therealmik commented 6 years ago

Hi,

The Mac install requires a native messaging json file (like the one in the deb subdir), as well as a plist to install it.

Unfortunately I lost most of the Mac packaging stuff in the conversion to open source, and I'm not sure of the best way to do Mac packaging/installers.

ghost commented 6 years ago

Did anybody get it to run on macOS? I have the same issues.

mehdideveloper commented 6 years ago

@nitramabuar I've built the extension on Ubuntu, and installed on Mac. Also built and installed the native messaging part on Mac and installed the json file (but not the plist); Now when I run Chrome from command line (to see the errors), here's one error without further details that's probably related to this:

Unable to read nativeMessage: EOF

therealmik commented 6 years ago

Hi,

I've been building on Mac, although I had to set my max open files pretty high. If it fails due to maxfiles, just keep re-running and it'll get further.

The EOF error is ok (I should probably not log it) - it means that nativeMessaging is getting called.

mehdideveloper commented 6 years ago

@therealmik Thanks, but the problem is that the extension complains about the native part (it says the native part is not installed; I've tried different combinations of options, but no success; For example I've installed the ".json" file in both user and system directories for NativeMessageing, and I've also copied the detanglenm to /usr/local/bin, so it can be called by others. I've also restarted Chrome to make sure it reloads everything)

freaksdotcom commented 4 years ago

Building chrome_ext will succeed if you use rules_nodejs-0.5.3 instead of 0.3.1