search

google / devlibrary

Source code for Google Dev Library
https://devlibrary.withgoogle.com
Apache License 2.0
184 stars 82 forks source link

Appear emojis in code blocks #329

Open skydoves opened 2 years ago

skydoves commented 2 years ago

Description

If code blocks include :${value}: string, emojis appear in code blocks like the following screenshots:

Screen Shot 2022-02-03 at 10 43 08 AM

Screen Shot 2022-02-03 at 10 43 35 AM

The full dependency sentence should be like the below:

implementation "com.github.skydoves:balloon:1.4.1"

I guess rendering emojis for the markdown content should filter the code blocks.

Relevant Links

Thanks, Google Dev Library team for building awesome projects!

samtstern commented 2 years ago

@skydoves thanks for reporting this! This is an interesting edge case. I guess we'll have to do the emoji replacement step on the final HTML so that we can know if it's inside a <pre> or not.

thatfiredev commented 2 years ago

Fixed in #335 This issue can be closed now