Closed 26damb closed 8 months ago
Visit the preview URL for this PR (updated for commit 8f39cca):
https://ugc-site-dev--pr748-title-undefined-bug-ot3b9ju8.web.app
(expires Thu, 12 Oct 2023 18:06:36 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: d2b0e641c7bcc746f492b050f282a6d0404c848d
LGTM
The previous Vue Router OG Meta logic I had does not work for our use case since crawlers from previews act before the meta data gets added.
I removed it and have placed the default preview image statically within index.html instead.
If we want the preview image to be different dynamically we would need a server side rendering solution - and currently we don't have this - which would be a larger task...
Merging this PR would make the title and preview image the same across all pages for dev library. If we wanted different titles and images, we would need to do my suggestion (or find another alternative)
Thoughts?