google / differential-privacy

Google's differential privacy libraries.
Apache License 2.0
3.07k stars 346 forks source link

Relax dependency for scipy~=1.7.1 in dp_accounting #236

Closed simonhkswan closed 1 year ago

simonhkswan commented 1 year ago

It would be extremely helpful if the scipy requirement located here:

https://github.com/google/differential-privacy/blob/e59bbcf86a5febcbbe6b2e5ebea37ee52457cf36/python/requirements.txt#LL9C1-L9C13

was changed from

scipy ~= 1.7.1

to:

scipy ~= 1.7

As the former means that anyone using this packaged must use scipy == 1.7.*. Looking at the usage of scipy in the repo, there doesn't seem be an issue with using scipy >= 1.8.

dibakch commented 1 year ago

Thanks for the suggestion! We'll make this change and will push it to GitHub soon (~ within one week).

dibakch commented 1 year ago

This has been fixed in commit 2d7cceadf88ad3de6cc305655b8af74c0183147a