search

google / digitalbuildings

Digital Buildings (ontology and SDK) currently being used by Google internally to manage our own buildings.
Apache License 2.0
371 stars 137 forks source link

Brightness is a measurement not a measurement descriptor #290

Open pisuke opened 3 years ago

pisuke commented 3 years ago

@tasodorff @charbull I think brightness should be moved to measurement and not be a measurement descriptor. Thoughts? Thanks, F

pisuke commented 3 years ago

Also "saturation" should be a measurement and not a measurement description.

charbull commented 3 years ago

@pisuke can you send a pull request please?

tasodorff commented 2 years ago

@pisuke for saturation and brightness, what would the units be?

We can open a PR and fix this, but we will also need to see if this breaks anything that has already been defined in Carson.

charbull commented 1 year ago

@pisuke @tasodorff any updates on this? @mschulze17 fyi

abe-101 commented 1 year ago

@pisuke can you send a pull request please?

I'd be happy to contribute and open a pull request.

Is it just moving line: https://github.com/google/digitalbuildings/blob/17cd918512f052c5f4815292cda7246e50d08ac0/ontology/yaml/resources/subfields/subfields.yaml#L199 and line: https://github.com/google/digitalbuildings/blob/17cd918512f052c5f4815292cda7246e50d08ac0/ontology/yaml/resources/subfields/subfields.yaml#L219

to the measurement section?

charbull commented 1 year ago

@cstirdivant @tasodorff ptal