google / docsy-example

An example documentation site using the Docsy Hugo theme
https://docsy.dev
Apache License 2.0
472 stars 687 forks source link

Upgrade Docsy to v0.10.0-33-gfe0d785, add rtlcss pkg #322

Closed chalin closed 1 month ago

chalin commented 1 month ago

How this PR was prepared

Screenshot

Illustrates that the top-nav and footer are better than ever, in particular that the following have been fixed:

image

Contrast this with the previous iteration, via #305:

chalin commented 1 month ago

@theletterf - can PTAL

chalin commented 1 month ago

Merging now. @theletterf - feedback is still welcome.

theletterf commented 1 month ago

FWIW it looks good to me!

Could the feedback feature get translated?

chalin commented 1 month ago

FWIW it looks good to me!

Thank you!

Could the feedback feature get translated?

Yes, I've been waiting for a kind soul to submit a PR for https://github.com/google/docsy/issues/2019 😄