search

google / docsy

A set of Hugo doc templates for launching open source content.
https://docsy.dev
Apache License 2.0
2.63k stars 904 forks source link

Hamburger navigation menu not responsive #2029

Closed esthermmoturi closed 5 months ago

esthermmoturi commented 5 months ago

Environment

Problem

Hamburger navigation menu on the site is not responsive. I have been following this conversation and this conversation on the same but the issue is not resolved using the suggestions provided.

The example site(https://delicate-lamington-ca0cb8.netlify.app/docs/) provided by @LisaFC also has the same issue I am experiencing when in mobile view. Are there any resolutions?

chalin commented 5 months ago

Hi @esthermmoturi - please update to the latest official release of Docsy and Hugo to see if that addresses your problem.

esthermmoturi commented 5 months ago

Hey @chalin , unfortunately the update did not help. I am now running hugo v0.126.2+extended darwin/arm64 and github.com/google/docsy@v0.10.0

chalin commented 5 months ago

Can you provide a link to your website and repo? The hamburger navigation is working fine from https://www.docsy.dev/docs/.

esthermmoturi commented 5 months ago

Sure, here is the website and here is the repo. Please not that I haven't updated(hugo and docsy) on the main repo. I have pushed to this branch instead.

chalin commented 5 months ago

Thanks. Can you provide a link to your branch preview so that I can see the problem "live"?

esthermmoturi commented 5 months ago

I am not sure if this is what you meant but I can only preview on my local instance. Screenshot 2024-05-31 at 14 15 51

chalin commented 5 months ago

Thanks for the screenshot, but no I was hoping to be able to see this deployed on a publicly accessible server. Could you get your Docsy + Hugo PR merged into the main site?

esthermmoturi commented 5 months ago

I am unable to merge because there a lot of changes I have to look through and customize before users can access. I saw no changes introduced by the upgrades in regards to the scss file. Unless I am wrong. Only go.mod, go.sum changed. Is it possible for you troubleshoot using the main branch since the upgrade did not provide a resolve?

chalin commented 5 months ago

I understand. Sorry, but we don't have the resources to debug older releases of Docsy. Btw, as you validate your upgrade of Docsy and Hugo, make sure that you carefully walk through the CHANGELOG.md for the version sections that you've upgraded from (0.8.0 to 0.10.0). If you get the updated Docsy and Hugo onto the main production server, I'll have a look.

esthermmoturi commented 5 months ago

Thank you @chalin , I'll work on the upgrade then revert.

alexrashed commented 5 months ago

Hi @esthermmoturi! I just stumbled upon the same issue for our Hugo page using Docsy. Turns out the issue was that we customized the layout, and some of the layout has been adjusted in Docsy with the upgrade to Bootstrap 5, namely the data-toggle attributes, which has been renamed to data-bs-toggle (similar for data-target -> data-bs-target). Looking at your repo, I think you might be running into the same issue. Here's how we resolved this issue: https://github.com/localstack/docs/pull/1336

esthermmoturi commented 5 months ago

Thanks @alexrashed , I tested your suggested changes and it worked.