search

google / docsy

A set of Hugo doc templates for launching open source content.
https://docsy.dev
Apache License 2.0
2.63k stars 904 forks source link

Address Language Dropdown & Search Narrow Display Issue + Farsi Font Update #2057

Closed poursalavati closed 1 month ago

poursalavati commented 4 months ago

This pull request addresses two user interface issues:

Language Dropdown and Search Box in Narrow Display: Fixes the issue reported in #2035 and #1944 where the language dropdown menu (and search box) become inaccessible on narrow displays.

Farsi Font Update: Updates the Farsi font to the open-source Vazirmatn from Google Fonts. This improves compatibility and potentially resolves issues encountered with previous Vazir font implementations.

PS:
The PR has been updated to resolve an issue affecting the dark/light menu on medium and small screens. The updated code ensures consistent menu functionality across all screen dimensions:

Demo: https://deploy-preview-2057--docsydocs.netlify.app/
Multi-lingual demo: https://rdrp.ir

Before:

After:

Farsi Font correction + Dropdown menu

google-cla[bot] commented 4 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

poursalavati commented 3 months ago

Fixed a minor bug.

chalin commented 1 month ago

HI @poursalavati, thanks for your PR. Note that Docy's RTL support has been upgraded, for details see:

So I'm unsure which parts of this PR are still relevant. I'm going to close this for now. Feel free to resubmit PRs -- I strongly suggest submitted separate PRs for each issue resolved. If you aren't able, I'll revisit this PR later when I have the time. Thanks!