google / dopamine

Dopamine is a research framework for fast prototyping of reinforcement learning algorithms.
https://github.com/google/dopamine
Apache License 2.0
10.42k stars 1.36k forks source link

Minor bug for `frame_skip` at `AtariPreprocessing` #177

Open alirahkay opened 3 years ago

alirahkay commented 3 years ago

When setting frame_skip=1 in the AtariPreprocessing, we will always have t=1 in the step function (line 475 of atari_lib.py). And so, self.screen_buffer[0] never gets updated. Now considering the _pool_and_resize when frame_skip is one, transformed_image is exactly the resized self.screen_buffer[0], and so, it will never change in the entire episode.