search

google / dspl

Schema and utilities for Google Dataset Publishing Language
https://developers.google.com/public-data
BSD 3-Clause "New" or "Revised" License
60 stars 206 forks source link

Fix rows with multiple currency codes #42

Open nkrishnaswami opened 3 years ago

nkrishnaswami commented 3 years ago

Per @coto,

There are two Chilean Currencies, one is CLF also know UF, mostly used for real states, it is a currency with inflation included. The other currency is CLP, Chilean Peso. the currency used daily by Chilean people.

The file samples/google/canonical/currencies.csv conjoins these into one row with ID "CLP CLF" and description "Chilean Peso Unidades de fomento". Instead, there should be separate rows for each, with CLP described as "Chilean Peso" with symbol "$" and CLF described as "Chilean Unidades de fomento" with symbol "CF"

As is, they would fail to match either of the currencies, and the codes are never used together for a single value.

This is actually more widespread, with 24 entries exhibiting this problem, eg currencies for Bolivia, Colombia, Cuba, Haiti (where the second currency is USD). Bhutan, Mexico, etc.

Fixes #41

coto commented 3 years ago

Thank you! There is typo on the description:

Where says: "Chilean Unidades de fomento" with symbol "CF"

Should says: "Chilean Unidades de fomento" with symbol "UF"