google / earthenterprise

Google Earth Enterprise - Open Source
Apache License 2.0
2.67k stars 888 forks source link

Add IsUpToDate function for SharedStrings #1843

Closed lacrosse91 closed 3 years ago

lacrosse91 commented 3 years ago

Hi. Addresses #1842 and add IsUpToDate function for SharedStrings. This PR is for a performance change.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

lacrosse91 commented 3 years ago

@googlebot I signed it!

tst-lsavoie commented 3 years ago

Thanks for the PR @lacrosse91. The code looks good, but we'll need to do some testing before we merge it.

lacrosse91 commented 3 years ago

Thanks for review, @tst-lsavoie. I would appreciate if you could tell me what I have to do.

tst-lsavoie commented 3 years ago

@lacrosse91 you don't need to do anything right now. I want to do some testing on my end before giving a final approval.

lacrosse91 commented 3 years ago

Thanks for reply. I'm very happy to contribute to this great project.